search

WebMemex / webmemex-extension

📇 Your digital memory extension, as a browser extension
https://webmemex.org
Other
208 stars 45 forks source link

Delete page entries from db for single url. #67

Closed wimpykid26 closed 7 years ago

wimpykid26 commented 7 years ago

@Treora What I did was: Used findpagesbyurl and normalizeresults from deduplication branch. get the corresponding entries called db.remove

Please review. If there is any error I'll fix them ASAP.

wimpykid26 commented 7 years ago

@Treora any thoughts?

Treora commented 7 years ago

It looks like this PR also contains the bookmarks import code and other stuff that is not related to this issue, so the diff is too messy to be reviewed. By the way, I merged deduplication into master, so if you rebase onto master you can also use the findPagesByUrl.

wimpykid26 commented 7 years ago

@Treora Apologize for the mess. Something went wrong while creating the branch. cleared the diff. used findPagesByUrl to get corresponding entries of same url.

wimpykid26 commented 7 years ago

screenshot from 2017-03-21 01-39-12 @Treora Cleaned the code as you said. Made the pagesResult return value into a promise and rebuilded search index after the promise is returned.

Treora commented 7 years ago

The essence is not bad, but it's still only half the solution here; closing due to inactivity.