search

WebMemex / webmemex-extension

📇 Your digital memory extension, as a browser extension
https://webmemex.org
Other
208 stars 45 forks source link

Added date time to filter search.(Continued from PR #66 ) for issue #26 #74

Closed RajPratim21 closed 7 years ago

RajPratim21 commented 7 years ago

@Treora @oliversauter because of certain version control reasons previous version was behaving strangely now I have added all the stuff in this repo to keep the code clean and understandable, for issue #26

Treora commented 7 years ago

@RajPratim21: Could you work on the language parser to a separate branch, and make a separate PR for that when that's ready? Finishing and merging one feature at a time makes things much easier.

You may find it worth reading some git tutorials on branching and rebasing. For this change, I would commit all my changes, run git branch time_nlp to make a new branch from the current branch, then run git reset --hard 1bc1238 to remove the last commit from this branch (watch out, this will delete any edits that you did not commit yet!). And then git push -f to update to github (-f is required to force an update that is not simple continuation of the branch).

RajPratim21 commented 7 years ago

yes , I will do the required @Treora . ,

Treora commented 7 years ago

@obsidianart: sorry for not communicating this in this thread, but I told Raj I would fix up this code today; probably ticking off most of your review remarks. Thanks though!

RajPratim21 commented 7 years ago

@Treora I am fixing @obsidianart marks, to make it easier for you to clean up and I am also about to add the git branch and these stuffs.

Treora commented 7 years ago

@RajPratim21: no need to fix remarks, I am already close to pushing my version. If you just remove the nlp-commit, that would be fine.

RajPratim21 commented 7 years ago

@Treora I removed the nlp commit and already done some minor changes , hope that don't cause much trouble.

Treora commented 7 years ago

@RajPratim21: I meant removing the commit, not reverting it. Also creating a new branch should not show up in this one. As said, studying some git tutorials for dealing with branches and rebasing them may help a lot.

Anyhow, I build onwards from what you made. I could propose it as a PR to your branch, but it may be easier if I just close this one and create a new PR again. ;)

RajPratim21 commented 7 years ago

@Treora , I apologise for the trouble caused, Thank you for cleaning the code and the final cleanup, ah, you can go for the PR :) .