search

WebMemex / webmemex-extension

📇 Your digital memory extension, as a browser extension
https://webmemex.org
Other
208 stars 45 forks source link

build on @reficul31's work a clean overhaul of the overview page. #82

Closed blackforestboi closed 7 years ago

blackforestboi commented 7 years ago

the same changes as the unintended commit as a proper pull request.

Overhaul of the overview, based on @reficul31's work. (#40)

Screenshot

screen shot 2017-04-02 at 02 44 33

reficul31 commented 7 years ago

Thanks @oliversauter . I thought the PR was merged. Although this code looks much more cleaner.

Treora commented 7 years ago

It would have been cleaner to continue from @reficul31's branch, possibly after rebasing it onto master (you could even make a PR to his branch). Now it is hard to see what you wanted to change, and you reinsert some old stuff that was changed or removed.

The style changes themselves seem good; the code still needs a clean up, which was a reason why it was not merged yet.

blackforestboi commented 7 years ago

@Treora Ok, next time will try to do it with rebase. I took the fork of reficul and compared the files with with the current master. I inserted the necessary divs and classes into the css files and removed things that are not needed anymore (i.e. caption class) Also I renamed the existing classes to have more descriptive titles of what they actually do.

you reinsert some old stuff that was changed or removed.

I saw that I didn take the new file path 'src/page-viewer' from the current master in file visitListItem.js. Any other things?

In the lastest commits I added a few other improvements, as seen in the commit message.

Here is the new screenshot.

screen shot 2017-04-02 at 12 08 16

reficul31 commented 7 years ago

@oliversauter @Treora Please tell me if I could assist in any way

Treora commented 7 years ago

Continued in #55, issue resolved in de16361.