Issue #72 -- Add a Linter

reficul31 commented 7 years ago

Features of the PR.

Adds eslint to the project for consistent styling
Adds editor config to the project
Configures to remove most style errors and warnings.

@Treora Please take into account that the PR still has some errors. Please either remove the errors or remove the lint itself. Please check and see if the rules are to the maintainers liking, or they can always be changed. Thanks.

USAGE

sudo npm run lint -- for checking the errors in the lint
sudo npm run lint-fix for automatically fixing the errors

reficul31 commented 7 years ago

There are 10(5 warnings and 5 errors) persisting errors that I cannot resolve as they require some big design decisions. It would be really helpful if someone could help me with them.

no-unused-vars error

This error finds its source. It is currently set to warning. Places of occurrence

src/activity-logger/background/log-page-visit.js => (finalPagePromise , visit) both are unused vars

react/no-unused-prop-types error

This error finds it source. It is currently set to warning. Places of occurrence.

src/options/layout.jsx => (location, children) both are unused prop types

prefer-promise-reject-errors error

This error finds its source. It is currently set to error. Places of occurrence

src/util/event-to-promise.js => line 58

promise/catch-or-return error

This error finds its source. It is currently set to error. Places of occurrence

src/util/tab-events.js => line 29

handle-callback-err error

This error finds its source. It is currently set to error. Places of occurrence

src/util/webextensionRPC.js => line 27 and 17 src/util/when-all-settled.js => line 3

These are all the errors that are still there. If we could remove all the errors or remove their lint rules then the code will be fully clean. I will continue looking for more rules that can help make the project more consistent. Thanks. Once the rules are finalized and integrated I will continue to add the git hook.

Treora commented 7 years ago

Thanks for the PR. I will do another round of changes to remove (or suppress) the remaining warnings/errors.

Treora commented 7 years ago

Done & merged. GitHub seems not to have detected that, so closing this manually. Thanks for the effort!

reficul31 commented 7 years ago

@Treora thanks for all the help!!

WebMemex / webmemex-extension