search

WebOfTrust / cesrox

Rust implementation of core CESR encoding format. A bridge to the beautiful island.
Apache License 2.0
2 stars 8 forks source link

Error handling specificity #8

Closed kentbull closed 1 year ago

kentbull commented 1 year ago

This adds error handling specificity in the IdentifierPrefix FromStr implementation.

This also cleans up some IDE paths and adds them to the .gitignore.

kentbull commented 1 year ago

The tests I updated do target the new code I added. See the new match clauses in the assertions. I can add separate tests just for that if you would rather.On Dec 2, 2022, at 8:05 AM, Kevin Griffin @.***> wrote: @m00sey requested changes on this pull request.

You added granularity to the code, you should update the tests to test your additions. I believe that was previously covered code.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

m00sey commented 1 year ago

Just need to fix the formatting

kentbull commented 1 year ago

Yeah, it is easy to miss as it’s a bit non-obvious. There was a subtle bug in the prior test code that I also missed the first time I read it. Only when I was stepping through the debugger did I find that the Deserialization error was occurring rather than a Base64Decode error.I’ll get the format update in this afternoon MST.On Dec 2, 2022, at 11:12 AM, Kevin Griffin @.***> wrote: Just need to fix the formatting

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

kentbull commented 1 year ago

There are two more missing spots that came up during review where error handling is missing. They will be added tomorrow.