Closed lenkan closed 8 months ago
If you rebase on development now, these tests should pass and we can merge it in
If you rebase on development now, these tests should pass and we can merge it in
:+1: Rebased it now.
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
0621cdb
) 91.22% compared to head (0f16966
) 91.22%.
Files | Patch % | Lines |
---|---|---|
src/keria/core/longrunning.py | 0.00% | 1 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Yes, was planning to give it a go. It will at the earliest be tomorrow. Probably not until next week due to the holidays. (Have some other things needing to get done before the week ends).
@lenkan any update on adding the test?
No, sorry. Been AFK for two weeks. Anyone feel free to pick it up if they need it done more urgently than myself. :)
This was fixed in another PR already merged.
Closes #150
I could not find any tests for this feature to update and currently do not have time to write something from scratch. Creating the PR anyway and you can decide if you want to takeover, wait for the tests or just merge it.
We are still not able to retrieve the updated state by using the key states query endpoint though. But that is another issue.