search

WebOfTrust / keria

KERI Agent in the cloud
https://keria.readthedocs.io/en/latest/
Apache License 2.0
17 stars 26 forks source link

ChallengeVerifyResourceEnd does not use the required AID name parameter #174

Closed lenkan closed 5 months ago

lenkan commented 5 months ago

Currently, the ChallengeVerifyResourceEnd requires the path parameter name to specify an AID alias name. However, the value for the specified hab is not being used except for checking if it exists. See implementation:

https://github.com/WebOfTrust/keria/blob/f24cf4b01932916cc640ff6f20ffda6f641c1ad2/src/keria/app/aiding.py#L947-L1067

From what I can tell, the challenge verification resource is only using the agent hab, so it does not need the AID name. In my opinion, if the AID hab is not being used, the parameter should not be required.

lenkan commented 5 months ago

Related to https://github.com/WebOfTrust/keria/issues/142 and https://github.com/WebOfTrust/keria/issues/127

lenkan commented 5 months ago

Fixed by #179