Closed lenkan closed 2 months ago
From our keri dev meeting: This was re-confirmed a few weeks ago. Likely using main but will be verified by @lenkan .
Can we use the multisig-vlei-issuance test to reproduce the issue?
Also, have you try issuing from kli
to see if it's only a KERIA issue?
from keripy it's working fine (see Daniel Lenksjö in the VLEI field):
kli vc export --name holder --alias holder --said ELmkMDGm8gRTONIGB3jHVINEth72KiUpTyRnaXKKslTV {"v":"ACDC10JSON000192_","d":"ELmkMDGm8gRTONIGB3jHVINEth72KiUpTyRnaXKKslTV","i":"EKxICWTx5Ph4EKq5xie2znZf7amggUn4Sd-2-46MIQTg","ri":"ELjERDs4x3K9ShHeoxQGXQXrPfHwKRqghKuI-UzphTxH","s":"EBfdlu8R27Fbx-ehrqwImnK-8Cm79sqbAQ4MmvEAYqao","a":{"d":"EFBekeyIO5XilQk6RHmcKy1M2UD_6GVCd34C3L2ITFEN","i":"ELjSFdrTdCebJlmvbFNX9-TLhR2PO0_60al1kQp5_e6k","dt":"2024-04-25T20:52:50.700187+00:00","LEI":"Daniel Lenksjö"}}-IABELmkMDGm8gRTONIGB3jHVINEth72KiUpTyRnaXKKslTV0AAAAAAAAAAAAAAAAAAAAAAAEHGIonO2JA0uy0ZKNaKa7lIzBOO_cK8CBHq3xSIBvx2k%
We can narrow the problem to signify/KERIA.
I found that the Serder class in signify-ts
was computing the size of the SAD from the string and not from the real bytes. That creates a size error in the version string when special characters takes two bytes in binary.
I submitted the PR https://github.com/WebOfTrust/signify-ts/pull/253
Thanks a lot for the fix. I guess this issue is in the wrong place then. I will close it, and since you already have a PR for it in signify-ts, we will use that to track. Nice work!
I think that KERIA crashes when the validation fails. We should fix it to not crash.
@rodolfomiranda Good point. It should validate then return HTTP 400? Do you think we should re-open this issue or create a new one?
I just retested and I think it does not crash now, but return 500 instead of 400. Creating a new one is fine for me
fantastic work @rodolfomiranda ! i'll add the new one to the top 10 and add this to the fixed section of the top10.
I tried to issue an ECR credential with my name "Daniel Lenksjö" as the "personLegalName". This causes keria to fail with an internal server error.
Stack trace: