Closed rodolfomiranda closed 3 months ago
still working on tests
Attention: Patch coverage is 91.66667%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 93.07%. Comparing base (
c38a54b
) to head (0cdcc49
). Report is 1 commits behind head on development.
Files | Patch % | Lines |
---|---|---|
src/keria/app/aiding.py | 84.84% | 5 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Cross posting from signify-ts: https://github.com/WebOfTrust/signify-ts/pull/241#pullrequestreview-1978910667
Open question... since we are changing the API anyways. Is there currently any benefit of using the event type as an object field key rather than just relying on the event payload t
property? I'll illustrate with an example what I mean:
Currently:
POST /identifiers/name/events
{
"rot": { ...rot payload },
"sigs": [...sigs]
}
POST /identifiers/name/events
{
"ixn": { ...ixn payload },
"sigs": [...sigs]
}
Rather than:
POST /identifiers/name/events
{
"event": { t: "rot/ixn", ...rot/ixn payload },
"sigs": [...sigs]
}
The switch on backend would be to check body.event.t === "ixn" or body.event.t === "rot"
.
This PR modify the
IdentifierResourceEnd
endpoint in the following way:/identifiers/{name}
: used to rename an alias and no longer acceptsrot
andixn
events/identifiers/{name}/events
: used to createrot
andixn
events/identifiers/{name}
: used to delete an aliasrelated to this issue #216 , and Discord this discussion: