WebOfTrust / keria

KERI Agent in the cloud
https://keria.readthedocs.io/en/latest/
Apache License 2.0
16 stars 26 forks source link

fix: multisig join operation never resolves #236

Closed lenkan closed 2 months ago

lenkan commented 2 months ago

Attempt to fix issue reported here: https://github.com/WebOfTrust/signify-ts/issues/227

With this change, the commented out steps here: https://github.com/WebOfTrust/signify-ts/pull/255/files#diff-6a2529a7963a536ba8e1b3c7f9c22eddeba360f49bdbc140a039df692ffc168aR366-R367 resolves.

lenkan commented 2 months ago

Test error seems unrelated:

ImportError while importing test module '/home/runner/work/keria/keria/tests/app/test_credentialing.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/importlib/__init__.py:90: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
tests/app/test_credentialing.py:[15](https://github.com/WebOfTrust/keria/actions/runs/8896850173/job/24430429603?pr=236#step:6:16): in <module>
    from keri.core.eventing import TraitCodex, SealEvent
E   ImportError: cannot import name 'TraitCodex' from 'keri.core.eventing' (/opt/hostedtoolcache/Python/3.12.2/x64/lib/python3.12/site-packages/keri/core/eventing.py)
pfeairheller commented 2 months ago

The TraitCodex and MacOS problem are now fixed on main, please rebase to pick them up

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.82%. Comparing base (5f06007) to head (caad67b). Report is 10 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #236 +/- ## ========================================== - Coverage 93.08% 92.82% -0.27% ========================================== Files 38 37 -1 Lines 7002 6982 -20 ========================================== - Hits 6518 6481 -37 - Misses 484 501 +17 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

lenkan commented 2 months ago

Perfect.

Looks like the branch protection rule needs updating after the build changes. I commented in #237.