search

WebOfTrust / keria

KERI Agent in the cloud
https://keria.readthedocs.io/en/latest/
Apache License 2.0
16 stars 26 forks source link

Feat/delegation approval endpoint #250

Closed 2byrds closed 3 weeks ago

2byrds commented 1 month ago

A fresh PR based on work and feedback from https://github.com/WebOfTrust/keria/pull/248

  1. I will change the keri dependency to the 1.2.0-dev5 tag once it is available.
  2. Adds delegation logic to delegating.py and tests in test_delegation.py
  3. Adds "/identifiers/{name}/delegation" end point per review comments from previous PR.
  4. Passes IdentifierResourceEnd, similar to how credentialing.py, per previous PR review comment.
  5. Only addresses the interaction case. A separate issue can be generated for handling/testing the rotation case.
  6. Extends long running 'delegation' operation to handle delegator approval case.
  7. Integration tested with updates to signify-ts which adds support for the delegation endpoint.
codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 91.94631% with 12 lines in your changes missing coverage. Please review.

Project coverage is 93.06%. Comparing base (caad67b) to head (18d3ad7). Report is 13 commits behind head on main.

Files Patch % Lines
src/keria/app/delegating.py 87.80% 5 Missing :warning:
src/keria/core/longrunning.py 75.00% 5 Missing :warning:
tests/app/test_delegating.py 97.36% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #250 +/- ## ========================================== + Coverage 92.82% 93.06% +0.23% ========================================== Files 37 36 -1 Lines 6982 7121 +139 ========================================== + Hits 6481 6627 +146 + Misses 501 494 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pfeairheller commented 3 weeks ago

You need to rebase with main to resolve the conflict.