WebOfTrust / keria

KERI Agent in the cloud
https://keria.readthedocs.io/en/latest/
Apache License 2.0
16 stars 26 forks source link

Fix/del rot smid rmid tests #254

Closed 2byrds closed 2 weeks ago

2byrds commented 3 weeks ago

Catches KERIA up with KERIpy changes AND provides all functionality necessary for SIGNIFY-TS integration tests to pass, especially multisig-vlei-issuance but also fixes for rotation, salty, and delegation

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 92.70073% with 20 lines in your changes missing coverage. Please review.

Project coverage is 93.06%. Comparing base (18d3ad7) to head (76d9a54). Report is 1 commits behind head on main.

Files Patch % Lines
src/keria/app/aiding.py 83.00% 17 Missing :warning:
src/keria/app/grouping.py 80.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #254 +/- ## ======================================= Coverage 93.06% 93.06% ======================================= Files 36 36 Lines 7121 7198 +77 ======================================= + Hits 6627 6699 +72 - Misses 494 499 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

2byrds commented 2 weeks ago

There is a small amount of overlap with https://github.com/WebOfTrust/signify-ts/pull/234/files but we'll adjust once either is merged.

2byrds commented 2 weeks ago

@pfeairheller I have made all the updates based on your review. I also added a small change to grouping.py to address @daviddm issue and corresponding PR which contains an additional signify-ts test (https://github.com/WebOfTrust/signify-ts/pull/258) that will now pass and can be merged after this.

I also ran against all original singify-ts integration tests again: image