Closed 2byrds closed 2 weeks ago
Attention: Patch coverage is 92.70073%
with 20 lines
in your changes missing coverage. Please review.
Project coverage is 93.06%. Comparing base (
18d3ad7
) to head (76d9a54
). Report is 1 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
src/keria/app/aiding.py | 83.00% | 17 Missing :warning: |
src/keria/app/grouping.py | 80.00% | 3 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There is a small amount of overlap with https://github.com/WebOfTrust/signify-ts/pull/234/files but we'll adjust once either is merged.
@pfeairheller I have made all the updates based on your review. I also added a small change to grouping.py to address @daviddm issue and corresponding PR which contains an additional signify-ts test (https://github.com/WebOfTrust/signify-ts/pull/258) that will now pass and can be merged after this.
I also ran against all original singify-ts integration tests again:
Catches KERIA up with KERIpy changes AND provides all functionality necessary for SIGNIFY-TS integration tests to pass, especially multisig-vlei-issuance but also fixes for rotation, salty, and delegation