search

WebOfTrust / keria

KERI Agent in the cloud
https://keria.readthedocs.io/en/latest/
Apache License 2.0
18 stars 29 forks source link

Allowing prefixes in identifiers endpoint #264

Closed rodolfomiranda closed 2 months ago

rodolfomiranda commented 3 months ago

This PR is an implementation of #217 and #202, fixing the problem of aliases with special characters . The changes allow endpoints of the form /identifiers/{name} to accept an alias or a prefix in the name path. If the value is valid for both prefix and alias, the prefix is prioritized. Basically, the PR replace: hab = agent.hby.habByName(name) with hab = agent.hby.habs[name] if name in agent.hby.habs else agent.hby.habByName(name)

codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 90.90909% with 5 lines in your changes missing coverage. Please review.

Project coverage is 93.06%. Comparing base (18d3ad7) to head (0bde30f). Report is 3 commits behind head on main.

Files Patch % Lines
src/keria/app/aiding.py 83.33% 3 Missing :warning:
src/keria/app/credentialing.py 90.00% 1 Missing :warning:
src/keria/app/delegating.py 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #264 +/- ## ======================================= Coverage 93.06% 93.06% ======================================= Files 36 36 Lines 7121 7198 +77 ======================================= + Hits 6627 6699 +72 - Misses 494 499 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

rodolfomiranda commented 2 months ago

I screw up the PR when rebasing. It picked other commits. I created a new clean one in #269 and I'm closing this.