Open rodolfomiranda opened 3 days ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 93.11%. Comparing base (
18d3ad7
) to head (50543d8
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Very helpful feature!
Question: I am not familiar with the notifier implementation, but this looks like it would load all notes in to memory, then filter them? Would it make sense to instead implement the filtering in keripy, utilizing the iterator to avoid loading all notes into memory?
That's a good point. The optimal way is to implement it in keripy
but it needs to run the iterator also on the countAll
function. However, for the order
part we still need to get them all in memory before pagination.
I can move it there easily, but I need the feedback from others specially @pfeairheller. If we are in agreement, I'll adapt this one and create a onother in keripy.
This PR address issue #266 . It adds to
NotificationCollectionEnd
three optional query parametersread
to filter by theread
property of the note (true or false).route
to filter by the router
property in the attributes section (a
) if exists.order
to order the results bydatetime
inasc
ordesc
order.