search

WebOfTrust / keria

KERI Agent in the cloud
https://keria.readthedocs.io/en/latest/
Apache License 2.0
20 stars 31 forks source link

fix: docker image reference cannot contain uppercase characters #311

Closed lenkan closed 1 month ago

lenkan commented 1 month ago

Using WebOfTrust/keria as the image name causes docker to choke and try to publish to a docker registry hosted at WebOfTrust instead of docker.io. This is what happened here: https://github.com/WebOfTrust/keria/actions/runs/11315384968/job/31466498211

Closes #309

Read more here: https://docs.docker.com/reference/cli/docker/image/tag/

PATH: The path consists of slash-separated components. Each component may contain lowercase letters, digits and separators. A separator is defined as a period, one or two underscores, or one or more hyphens. A component may not start or end with a separator. While the OCI Distribution Specification supports more than two slash-separated components, most registries only support two slash-separated components. For Docker's public registry, the path format is as follows:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 93.74%. Comparing base (18d3ad7) to head (be40c0d). Report is 27 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #311 +/- ## ========================================== + Coverage 93.06% 93.74% +0.68% ========================================== Files 36 36 Lines 7121 7979 +858 ========================================== + Hits 6627 7480 +853 - Misses 494 499 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

iFergal commented 4 weeks ago

@2byrds can we try a dev release again now that this is merged?

2byrds commented 4 weeks ago

@2byrds can we try a dev release again now that this is merged?

@iFergal what do you want the version to be?

iFergal commented 4 weeks ago

@2byrds 0.2.0-dev4 makes sense to me since I guess we haven't moved to the new released keripy version yet (#300)