Closed rodolfomiranda closed 3 months ago
Any interest in fixing the other usages of datetime vs helping.nowISO() @rodolfomiranda 😬
Any interest in fixing the other usages of datetime vs helping.nowISO()
I could only find datetime.datetime
used in signaling.py
. I updated it. The rest of keripy
seems to be ok since datetime
is only used for timedelta
.
Any interest in fixing the other usages of datetime vs helping.nowISO()
I could only find
datetime.datetime
used insignaling.py
. I updated it. The rest ofkeripy
seems to be ok sincedatetime
is only used fortimedelta
.
Thanks, appreciate you taking the extra time.
Can we please explain in the description of the PR why this change is being made? The helping functions are used in many other places in KERIpy, specifically for time in KERI events and credentials. Why are you proposing we change them for only this small subset of date usages?
If the date functions are wrong, why not fix them?
If the date functions are wrong, why not fix them?
date functions are correct, but were not applied correctly in a couple of lines in notifying.py
and signaling.py
Should be using helping.nowIso8601() or helping.toIso8601 everywhere there is a datetime string (non CESR encoded). Or Dater instance if want CESR encoded datetime
Notes that are not initiated with a
dt
parameter, are being created with a defaultdt
that don't follows the ISO 8601 format. The class use the functiondatetime.datetime.now().isoformat()
to create the string timestamp that result in a value without timezone or offset such as2023-10-05T14:48:23.123456
. Instead,keripy
normal usehelping.nowIso8601()
to create the timestamp that result in values like2021-06-27T21:26:21.233257+00:00