WebOfTrust / polaris-web

Apache License 2.0
1 stars 6 forks source link

Implementation suggestion for Nord Vlei Extension #17

Closed HunnySajid closed 1 month ago

HunnySajid commented 1 month ago

In polaris-web, there are three different methods with a slightly different implementation as per the use cases of signify-polaris-web. Namely:

Signify Extension

If authorize call is made user can select both credential or aid If authorizeAid call is made user can only select aid If authorizeCred call is made user can only select a credential

Screenshot 2024-08-06 at 7 54 42 PM Screenshot 2024-08-06 at 7 54 29 PM

However, this behavior is a bit different in Nord Vlei. NordVlei extension only listens to authorize method call and based on that displays a list of credentials to be selected.

State of NordVlei extension when authorize call is made from polaris-web

Screenshot 2024-08-06 at 7 53 56 PM

We want to make Reg Pilot Web APP compatible with both NordVlei and Signify Extension. If we use authorize: In Signify Extension, it would allow user to pick any of Credential or AID, we dont want that. If we use authorizeCred: it is not implemented in NordVlei and it would not be listened.

Suggestion: Our suggestion is to replace authorize method in NordVlei with authorizeCred. That way it would be compatible for both of the extensions.

@2byrds

2byrds commented 1 month ago

@HunnySajid thank you for the details. @lenkan and @daviddm lets discuss when you return.

lenkan commented 1 month ago

Thanks for the detailed description @HunnySajid ! We have added support for authorizeCred in our extension now, we just need to wait for approval before publishing the updated extension.

2byrds commented 1 month ago

Thanks for the detailed description @HunnySajid ! We have added support for authorizeCred in our extension now, we just need to wait for approval before publishing the updated extension.

That's great, go team!

lenkan commented 1 month ago

It is now published in version 0.0.5 of the extension in the chrome store.

HunnySajid commented 1 month ago

It is now published in version 0.0.5 of the extension in the chrome store.

much appreciated 👏