WebOfTrust / signify-browser-extension

Apache License 2.0
5 stars 6 forks source link

Demo review changes #93

Closed 2byrds closed 7 months ago

2byrds commented 7 months ago
HunnySajid commented 7 months ago
  • [x] Abbreviated identifiers should have hover over to see the full identifier
  • [x] On identifier creation, if there is a failure, supply an error message
  • [ ] Session can be interrupted while the app is running, this needs a fix or clever way to prompt user to reconnect.
  • [x] All screens need a way to notify user if disconnected or some other error.
  • [x] The credential 'Select' button needs more padding
  • [x] The identifier 'Select' button needs more padding
  • [x] Credential 'sign-in' button should not wrap
  • [ ] The example webapp should navigate to a welcome screen once sign-in successful. The welcome screen should tell the user what they signed in with and display the errors.

All except session interruption and last point, rest are covered in https://github.com/WebOfTrust/signify-browser-extension/pull/92

Separate task for session https://github.com/WebOfTrust/signify-browser-extension/issues/96 Separate task for the last point https://github.com/WebOfTrust/signify-browser-extension/issues/94

HunnySajid commented 7 months ago

Closing as it is merged with https://github.com/WebOfTrust/signify-browser-extension/pull/92