Closed miikeat closed 4 years ago
Note that line 40 also needs to be changed to "wpe-1.0" as well.
If anyone is interested - the diff to get this to compile:
diff --git a/cmake/FindWPE.cmake b/cmake/FindWPE.cmake
index 7f4ffd21cb34..a0624817630f 100644
--- a/cmake/FindWPE.cmake
+++ b/cmake/FindWPE.cmake
@@ -29,7 +29,7 @@
# ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
find_package(PkgConfig)
-pkg_check_modules(PC_WPE QUIET wpe-0.2)
+pkg_check_modules(PC_WPE QUIET wpe-1.0)
find_path(WPE_INCLUDE_DIRS
NAMES wpe/wpe.h
@@ -37,7 +37,7 @@ find_path(WPE_INCLUDE_DIRS
)
find_library(WPE_LIBRARIES
- NAMES wpe-0.2
+ NAMES wpe-1.0
HINTS ${PC_WPE_LIBDIR} ${PC_WPE_LIBRARY_DIRS}
)
``
As I committed a patch, this one can be closed. Indeed, older versions of wpewebkit and libwpe will suffer, but what would be the point in keeping this backward-compatible? If people want an old version, they still can use an older version of this backend too...
Agreed. This also avoid hackish code for no good reason.
I try to build meta-webkit with wpebackend 2.24 & libwpe 1.2 but since these versions WPEBackend-rdk fails to build:
With version 1.20180925:
Same happens with current master branch:
A more details can be found over here: https://github.com/Igalia/meta-webkit/pull/89
@philn also pointed out that probably this line might be the cause: https://github.com/WebPlatformForEmbedded/WPEBackend-rdk/blob/master/cmake/FindWPE.cmake#L32
According to this table https://wpewebkit.org/release/schedule/ (See Compatible Components) if WPEBackend-rdk is inteded to work with wpewebkit 2.24 and libwpe 1.2 then this line should probably look like this:
But I guess then it wouldn't work anymore with older versions of wpewebkit and libwpe!?!?