search

WebPlatformForEmbedded / WPEWebKit

WPE WebKit port (downstream)
213 stars 139 forks source link

[wpe-2.38] Regression in SVG lightning filter #1145

Closed Scony closed 1 year ago

Scony commented 1 year ago

To reproduce, run ACT-1345 test case from BBC cert suite, for that run:

2.28

228

2.38

238

Please note that the issue happens regardless of LBSE being used or not (ENABLE_LAYER_BASED_SVG_ENGINE option).

github-actions[bot] commented 1 year ago

Please add a wpe-x.xx version label to the issue.

Scony commented 1 year ago

Please add a wpe-x.xx version label to the issue.

I can't add labels...

woutermeek commented 1 year ago

Oh, well that is not good :) Let me check that.

Scony commented 1 year ago

Direct link to problematic SVG: https://certification.bbctvapps.co.uk/act/test/ui/187/svg-supports-filter-lighting/actual-lighting.svg

pgorszkowski-igalia commented 11 months ago

I backported the fix from the upstream which implements the same thing in clearer and proper way: wpe-2.38: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1235 wpe-2.42: https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1236

Scony commented 11 months ago

Thanks! I'll give it a try in upcoming week or two.

amol-virnodkar-infosys commented 10 months ago

I ported the fix(https://github.com/WebPlatformForEmbedded/WPEWebKit/pull/1235) with WPE 2.38 and tested the fix on a Broadcom based device, we are observing the issue in WPE 2.38 as below. The shades are bit darker in colour.

svg

We will be verifying this fix on a reference video accelerator device soon. @pgorszkowski-igalia Could you please check the behavior in the above image and provide your inputs.

Scony commented 10 months ago

@amol-virnodkar-infosys in the Firefox the shades are bit darker as well.

Scony commented 10 months ago

@pgorszkowski-igalia I forgot to mention - few weeks ago I was testing your changes and it's all good.

rychem commented 10 months ago

@pgorszkowski-igalia in context of darker 'actual rendering' reported by @amol-virnodkar-infosys - test results for wpe2.22 are the same as indicated above for 2.28 (expected=actual)

pgorszkowski-igalia commented 10 months ago

@amol-virnodkar-infosys , @rychem : I can confirm that in case of wpe 2.38 the actual results are a bit darker (RPi3B+).

It seems that also in upstream FELighting does not work correctly for ARM NEON. It is another part which does not work after refactoring change (similar to the FEComposite things). The fix will be provided in upstream and then backported.

@amol-virnodkar-infosys: nice finding, thanks

rychem commented 10 months ago

Thanks @pgorszkowski-igalia for confirmation. Is this ticket supposed to be reopened or other ticket is created for trackability ... ?

pgorszkowski-igalia commented 10 months ago

@rychem : maybe it would be better to create a separate ticket for it. Thanks.

amol-virnodkar-infosys commented 10 months ago

@pgorszkowski-igalia Created a new ticket - https://github.com/WebPlatformForEmbedded/WPEWebKit/issues/1274 as suggested by you. Thanks.