search

WebPlatformForEmbedded / WPEWebKit

WPE WebKit port (downstream)
213 stars 136 forks source link

[ARRISEOS-44876] : PIP video displays a black screen while transition… #1205

Closed suresh-khurdiya-epam closed 10 months ago

suresh-khurdiya-epam commented 11 months ago

PIP video displays a black screen while transitioning to the next episodes in 'itvx news' rail

ITVx uses MP4 progressive download for showing ITVx news videos. When a video ends (or it's about to end) the app will change the size of the

On Horizon as soon as the video ends, it will show a black box (see attached picture) instead of showing last frame played as browser or TiVo devices do.

  1. Reproducibility rate 100%

Scenario to reproduce

  1. Launch the ITVx App
  2. Play assets from itvx news rail
  3. Observe the behaviour while transitioning to next episode

Expected result PIP Video keeps playing until it finishes Actual results PIP video displays a black screen while transitioning to the next episodes in 'itvx news' rail

Screenshot from 2023-10-04 15-42-55

================================================================================================ Issue is seen only with Progressive based content. If we try same use case contents which are MSE based playback then no issue is seen on PIP, In PIP we can see last 10 seconds video is played.

But, in case of progressive , we are getting EOS message from G streamer and based upon this message, we are setting the pipeline state to READY which show the black screen in PIP. So, in this case, we have changed the pipeline state to PAUSED so that we can see Last frame in PIP instead of Black screen.

eocanha commented 10 months ago

This kind of problem of "losing" the last frame after the video has finished isn't reproducible in upstream WebKit (where we would ideally want to have this patch). I think it might be specific to some multimedia hardware platform used downstream. Could you share what hardware platform are you using, so we can add some ifdefs that only enable the change for that platform? Is it Broadcom Nexus?

eocanha commented 10 months ago

Patch submitted upstream for review as https://bugs.webkit.org/show_bug.cgi?id=264739 / https://github.com/WebKit/WebKit/pull/20415

eocanha commented 10 months ago

Backported and pushed to wpe-2.38 as https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/04b8550799567c356d1c1db3c291c81e03ed3fde. Closing issue.

BTW, @suresh-khurdiya-epam, the timeout for auto-demotion from PAUSED to NULL is currently set to 5 minutes. If you need more time or even to completely disable the timeout, ask for it.