search

WebPlatformForEmbedded / WPEWebKit

WPE WebKit port (downstream)
213 stars 136 forks source link

[wpe-2.38][webrtc] Build gstwebrtc with gst 1.18 #1216

Closed jacek-skiba-red closed 10 months ago

jacek-skiba-red commented 10 months ago

Based on GStreamerChecks.cmake gstwebrtc is supported from gstreame version 1.18. Added checks for types defined in version 1.20.

Alternative approach would be to support gstwebrtc from gstreamer version 1.20.

philn commented 10 months ago

I'm not in favor of this PR. 1.18 upstream is un-tested in the WebKit WebRTC backends. Some changes were backported from 1.20 to downstream 1.18 though. I'm not sure if those were merged in buildroot.

jacek-skiba-red commented 10 months ago

https://github.com/WebPlatformForEmbedded/WPEWebKit/tree/wpe-2.38/Source/cmake#L65 update this check to version 1.20?

philn commented 10 months ago

No we can't do that either (cc @modeveci ).

modeveci commented 10 months ago

@philn the backports are in wip branch. @jacek-skiba-red instead of this patch can you try to use backports phil mentioned: https://github.com/WebPlatformForEmbedded/buildroot/commits/igalia/wpe-2.38-gst-1.18-wip commits on May 15, 2023

jacek-skiba-red commented 10 months ago

Thanks @modeveci for pointing this. If we will choose gstwebrtc, then we will use @philn backports.