WebPlatformForEmbedded / WPEWebKit

WPE WebKit port (downstream)
211 stars 135 forks source link

Buffer end equals video duration for progressive video #1238

Closed suresh-khurdiya-epam closed 6 months ago

suresh-khurdiya-epam commented 9 months ago

Buffer end equals video duration for progressive video. Reproduction scenario:

  1. Connect with WebInspector
  2. Start DW/CNN application and play some long video.
  3. When video starts to play, check in WebInspector console:

document.getElementsByTagName('video')[0].buffered.end(0) + " " + document.getElementsByTagName('video')[0].duration Expected:

End buffer should not be equal to total video duration

Actual End buffer is equal to total video duration.

Similar fix was available in WPE 2.22. https://github.com/WebPlatformForEmbedded/WPEWebKit/blob/wpe-2.22/Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp

CNN APP: https://widgets.metrological.com/lightning/liberty/2e3c4fc22f0d35e3eb7fdb47eb7d4658#app:com.metrological.app.CNN

eocanha commented 6 months ago

Patch submitted upstream for review as https://bugs.webkit.org/show_bug.cgi?id=269203 / https://github.com/WebKit/WebKit/pull/24257.

eocanha commented 6 months ago

The patch landed upstream as https://github.com/WebKit/WebKit/commit/3e214abe945921fb2ebbf234c7bfd1dab35cea9e and was backported to wpe-2.38 as https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/eda256c32c4ffa4e7220d9390f1a50c8d5151c60 and to https://github.com/WebPlatformForEmbedded/WPEWebKit/tree/calvaris/wpe-2.42/upstream as https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/40f75eaaf38882cb0298092e3ab1ff66040fc202. Closing PR.