search

WebPlatformForEmbedded / WPEWebKit

WPE WebKit port (downstream)
213 stars 136 forks source link

[MSE SourceBuffer] Reset extra memory cost inside removedFromMediaSou… #1264

Closed asurdej-comcast closed 8 months ago

asurdej-comcast commented 9 months ago

…rce()

This allows SourceBuffer that was removed from media source to report memory that is actually in use. Otherwise it reports last value even if memory was relased already.

I think m_reportedExtraMemoryCost doesn't need to be reset as memory can not grow after removing SourceBuffer from media source. There is no way to reattach and data are not accepted also.

The same we did in 2.28 https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/34e8375728f5d25cd042e9aefb7d42f782c3adf8

eocanha commented 8 months ago

Submitted the patch upstream for review as https://bugs.webkit.org/show_bug.cgi?id=267350 / https://github.com/WebKit/WebKit/pull/22602.

eocanha commented 8 months ago

Patch landed upstream as https://github.com/WebKit/WebKit/commit/4fa545a246f2656f589c82517da3b66a79e129ba and packported to wpe-2.38 as https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/da14ef5ef780fa74de1d5b5679d1cfb0ce692f75 and to wpe-2.42 as https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/8472a26cc35901290e249ea409debf15fcb5e42a. Closing PR.