[GTK][WPE] PlatformDisplay::terminateEglDisplays() is never called - Githubissues

WebPlatformForEmbedded / WPEWebKit

WPE WebKit port (downstream)

210 stars 135 forks source link

[GTK][WPE] PlatformDisplay::terminateEglDisplays() is never called #1271

Closed pgorszkowski-igalia closed 6 months ago

pgorszkowski-igalia commented 6 months ago

https://bugs.webkit.org/show_bug.cgi?id=217655

Stop the run loop for GTK and WPE to ensure a normal exit, since we need atexit handlers to be called to cleanup resources like EGL displays.

Reviewed by Carlos Garcia Campos.

Shared/AuxiliaryProcess.cpp: (WebKit::AuxiliaryProcess::didClose):
WebProcess/WebProcess.cpp: (WebKit::WebProcess::initializeConnection):
WebProcess/WebProcess.h:
WebProcess/glib/WebProcessGLib.cpp: (WebKit::WebProcess::stopRunLoop):

Canonical link: https://commits.webkit.org/247678@main git-svn-id: https://svn.webkit.org/repository/webkit/trunk@290360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

pgorszkowski-igalia commented 6 months ago

This change introduced a regression in upstream (https://bugs.webkit.org/show_bug.cgi?id=238494) but the regression was related to GTK and seems to be safe for WPE. I discussed it with cgarcia.