Setting PlaybackRate=0 does not pause video for progressive video pla…

WebPlatformForEmbedded / WPEWebKit

WPE WebKit port (downstream)

210 stars 135 forks source link

Setting PlaybackRate=0 does not pause video for progressive video pla… #1272

Closed suresh-khurdiya-epam closed 6 months ago

suresh-khurdiya-epam commented 6 months ago

Description: Setting PlaybackRate=0 in the web inspector does not pause the video. Works fine for WPE 2.22. Additional info: you can set playbackRate=0.01 and video looks like paused, but playbackRate=0 is not changing playback rate at all.

How to reproduce:

open France24 app
play video from 'latest bulletins' (not live)
go to web inspector console
execute in the web inspector console: document.getElementsByTagName('video')[0].playbackRate=0

Actual result: Nothing changed on the playing content

Expected result: Video should be paused

eocanha commented 6 months ago

Submitted the patch upstream as https://bugs.webkit.org/show_bug.cgi?id=267601 / https://github.com/WebKit/WebKit/pull/22831.

eocanha commented 6 months ago

Commit landed upstream as https://github.com/WebKit/WebKit/commit/fa338d78104660c63562d8dd1b24a8f8207d72da and backported to wpe-2.38 as https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/b371bc5887bc9322794a773d0f2e3042404eb277. It hasn't been directly backported to wpe-2.42 because of conflicts and dependencies, but has been added to https://github.com/WebPlatformForEmbedded/WPEWebKit/commits/calvaris/wpe-2.42/upstream, which should be merged in the near future, as https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/dad59934a2f41fde6f65c8e61f2f2f6a15da6992. Closing PR.