search

WebPlatformForEmbedded / WPEWebKit

WPE WebKit port (downstream)
210 stars 135 forks source link

[wpe-2.38] Prevent journal files from wasting disk space #1280

Closed Scony closed 5 months ago

Scony commented 5 months ago

I'd like to gather some feedback on potential setting of PRAGMA journal_size_limit = 0; in local storage's SQLite database. What it does, is slightly improving the effectiveness of disk space usage at the slight expense of performance. I was wondering if it's maybe worth adding it behind some flag being controlled from settings perhaps?

magomez commented 5 months ago

I don't have a strong opinion for or against this. If saving space is a priority, we could add it, as I don't think the performance penalty is going to be that relevant. @modeveci what do you think?

modeveci commented 5 months ago

@magomez as you stated that the performance will not be relevant, then it is good to gain from diskspace. sure let's add it. this is what I have seen from provided description: "To always truncate rollback journals and WAL files to their minimum size, set the journal_size_limit to zero. "