search

WebPlatformForEmbedded / WPEWebKit

WPE WebKit port (downstream)
210 stars 135 forks source link

Allow GST_EVENT_CUSTOM_DOWNSTREAM_OOB to propagate when not handled #1296

Closed filipe-norte-red closed 4 months ago

filipe-norte-red commented 4 months ago

We may wish to use GST_EVENT_CUSTOM_DOWNSTREAM_OOB event for use cases beyond signaling an "attempt-to-decrypt"

modeveci commented 4 months ago

@calvaris @philn , is this ticket ready to merge?

calvaris commented 4 months ago

No, until I check it.

calvaris commented 4 months ago

Please provide a custom HTML to reproduce the issue.

filipe-norte-red commented 4 months ago

@calvaris , this was reproduced (and verified) with a feature that is not available on down/upstream repo yet, so cannot provide a page that allows verification with the current downstream version. I do see the same event being "used" in GStreamerMediaEndpoint::requestAuxiliarySender(), but am not familiar with that functionality to create a test case with it in a short time. I'm trying to upstream this particular fix as, while related, it seamed an independent issue that could be upstreamed right away.

calvaris commented 4 months ago

This landed upstream as r276144 and backported to 2.38 as 2d9c61e788ea and to wpe-2.42 as 222cb6346e37 .