search

WebPlatformForEmbedded / WPEWebKit

WPE WebKit port (downstream)
210 stars 135 forks source link

Wpe 2.38 quirks #1297

Closed philn closed 3 months ago

philn commented 4 months ago

Hold on, I forgot to remove one ifdef...

philn commented 4 months ago

Hold on, I forgot to remove one ifdef...

This fixed, the PR is ready for testing/review!

philn commented 3 months ago

Quirks should also allow changing playbin flags in MediaPlayerPrivateGStreamer::setPlaybackFlags . For example native-audio is Broadcom quirk.

I wasn't aware of that. Yeah definitely, @calvaris already suggested removing those native-video/etc ifdefs. I can take a look.

philn commented 3 months ago

I've rebased the branch and backported the changes requested by @emutavchi (see most recent commit).

modeveci commented 3 months ago

@emutavchi , Once you approved this PR, then I think we are ready to merge. @philn let's wait Eugene's approval and then we can continue.