Update GStreamerWebRTCProvider.cpp

WebPlatformForEmbedded / WPEWebKit

WPE WebKit port (downstream)

210 stars 135 forks source link

Update GStreamerWebRTCProvider.cpp #1318

Closed woutermeek closed 2 months ago

woutermeek commented 2 months ago

Initialize MediaCapabilitiesDecodingInfo by default for strict compiler settings

philn commented 2 months ago

Seems to happen on Ubuntu 22 with gcc. @dpino have you seen this issue?

Upstream with gcc 14 I haven't seen this issue.

dpino commented 2 months ago

I haven't seen a build issue related to this in the WPE-Linux-64-bit-Release-Ubuntu-LTS-Build bot (Ubuntu 22.04) lately. This bot builds with GCC11.4 (this is the default GCC version for Ubuntu 22.04). The bot builds with USE_GSTREAMER_WEBRTC:BOOL=ON.

philn commented 2 months ago

Well if that makes your build happier I think it's harmless. Let's keep this downstream though, since upstream doesn't seem affected by this issue.