Fix HEVC codec string parsing

asurdej-comcast commented 1 month ago

Codec string is first moved into lowercase and then compared in uppercase. This is backport of 5ee3f9a7c6a9 from upstream:

Two new failures media/media-can-play-case-sensitive-flac.html, media/media-can-play-type-case-sensitive.html https://bugs.webkit.org/show_bug.cgi?id=260625

Reviewed by Xabier Rodriguez-Calvar.

Codec string matching is now case-sensitive in the registry scanner.

LayoutTests/platform/glib/TestExpectations:
Source/WebCore/platform/graphics/gstreamer/GStreamerRegistryScanner.cpp: (WebCore::GStreamerRegistryScanner::initializeDecoders): (WebCore::GStreamerRegistryScanner::isContentTypeSupported const):

Canonical link: https://commits.webkit.org/267343@main

asurdej-comcast commented 1 month ago

Hi @philn Can you please take a look at this change? With https://github.com/WebPlatformForEmbedded/WPEWebKit/commit/95cae32e59cfdfad7cdd7139909bb47a7aed494e hevc parsing is broken and webkit rejects all hevc codecs (IsNotSupported) as parseHEVCCodecParameters() expects uppercase letters while we explicitly put codec into lowercase first Not sure why this patch was not backported with other changes

philn commented 1 month ago

Not sure why this patch was not backported with other changes

No special reason. I can backport this to 2.38.

WebPlatformForEmbedded / WPEWebKit

Fix HEVC codec string parsing #1337