[GStreamer] Critical warning when updating video sink stats of a player in error state

WebPlatformForEmbedded / WPEWebKit

WPE WebKit port (downstream)

213 stars 136 forks source link

[GStreamer] Critical warning when updating video sink stats of a player in error state #1388

Closed cadubentzen closed 1 month ago

cadubentzen commented 1 month ago

This is a backport from https://commits.webkit.org/264718@main upstream, authored by Philippe Normand.

Reviewed by Xabier Rodriguez-Calvar.

Don't attempt to gather video rendering metrics if the player hasn't created a video sink.

Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp: (WebCore::MediaPlayerPrivateGStreamer::updateVideoSinkStatistics):

Canonical link: https://commits.webkit.org/264718@main

eocanha commented 1 month ago

IMHO, this kind of trivial backports that don't cause much cherry-pick trouble (don't generate merge conflicts and potential problems) don't even need review. It's fine that you "document" them as a Pull Request, but I think you can even approve and merge it yourself.