WebPlatformForEmbedded / libwpe

General-purpose library specifically developed for the WPE-flavored port of WebKit.
BSD 2-Clause "Simplified" License
49 stars 36 forks source link

Setting zero as device scale factor wrecks havoc #89

Closed aperezdc closed 2 years ago

aperezdc commented 2 years ago

Reported by @philn in https://github.com/Igalia/cog/pull/384#issuecomment-991743007:

Also, shouldn't wpe_view_backend_dispatch_set_device_scale_factor() return an error or something when it receives a 0 factor? Because that's wrecking havoc :)

Probably we should check that the requested scaling factor is between reasonable limits, because I do not expect good things to happen by setting it too big either.