search

WebPlatformForEmbedded / libwpe

General-purpose library specifically developed for the WPE-flavored port of WebKit.
BSD 2-Clause "Simplified" License
49 stars 36 forks source link

Format CMakeLists.txt file #95

Closed donny-dont closed 2 years ago

donny-dont commented 2 years ago

Run cmake-format over the root CMake file to gain consistency in the file.

donny-dont commented 2 years ago

Ran cmake-format with the following Python configuration and then some manual cleanups.

with section("format"):
    line_width = 150
    tab_size = 2
    dangle_parens = True
    separate_ctrl_name_with_space = True

with section("markup"):
    enable_markup = False

I didn't touch the files in CMake because those seem like they were copied from elsewhere. Also those ones seem to tend more towards 4 space indentation while the root CMakeLists.txt seemed like it preferred 2 space indentation.

If 4 space indentation is preferred I'm fine with running that through.

philn commented 2 years ago

LGTM but maybe it'd make sense to teach the CI to run cmake-format if we want to ensure the style remains consistent.

donny-dont commented 2 years ago

I'm not super familiar with your CI but there is a GitHub action for it https://github.com/PuneetMatharu/cmake-format-lint-action if that's something you all want to do. If so I can push the config for it.

Its my understanding that Meson is the preferred build system from here on out. We did a bunch of work to make it so CMake could output VS projects that work on PlayStation so that's why we keep pushing that.

philn commented 2 years ago

There is a CI but it seems inactive for PRs. Not sure why :) https://github.com/WebPlatformForEmbedded/libwpe/blob/master/.github/workflows/ci.yml

donny-dont commented 2 years ago

Any time I've opened up a PR on libwpe the actions run in my fork https://github.com/donny-dont/libwpe/actions/runs/2005707166

I'm not super familiar with GitHub Actions so I can play with them and see if they work. I'm not sure if an action needs to be explicitly installed on the original repository though.