search

WebPlatformForEmbedded / libwpe

General-purpose library specifically developed for the WPE-flavored port of WebKit.
BSD 2-Clause "Simplified" License
49 stars 36 forks source link

Clarify CI workflows #96

Closed donny-dont closed 2 years ago

donny-dont commented 2 years ago

Rename ci.yml to build.yml since it is explicitly building the project and documentation. Also make this workflow run on PR because whether the build was successful was not being beamed to a status check.

Rename pr.yml to format.yml since it is explicitly ensuring that the source code is properly formatted.

donny-dont commented 2 years ago

This moves the context for the GitHub Actions into this repository rather than the fork. As you can see above this makes it so there are 3 status checks here, CI Build / linux, CI Build /windows and CI Source Formatting /format-cmake.

There aren't builds happening in my fork of libwpe so I think this is the way to go.

aperezdc commented 2 years ago

This moves the context for the GitHub Actions into this repository rather than the fork. As you can see above this makes it so there are 3 status checks here, CI Build / linux, CI Build /windows and CI Source Formatting /format-cmake.

There aren't builds happening in my fork of libwpe so I think this is the way to go.

Oh, so that was the reason! Thanks for the patch, somehow I managed to miss that GH Actions works in that way when setting up the CI 😅