feature: responsive past events on main page

WebPurple / site

Site of front-end community - WebPurple

https://www.webpurple.net

Other

39 stars 44 forks source link

feature: responsive past events on main page #265

Closed ro-abramov closed 5 years ago

ro-abramov commented 5 years ago

WIP

[x] responsive past events
[x] responsive upcoming events
[x] use rem units instead of pixels
[x] remove duplicated code
[x] fix photos position inside diamonds
[x] add past events link
[x] change to mobile first approach
[x] elaborate on items order
[x] fix the last issue with duplicated diamonds on dimensions from 599px to 768px

ro-abramov commented 5 years ago

Issues #168 #167

kitos commented 5 years ago

Looks great!!! ❤️ ❤️❤️

ro-abramov commented 5 years ago

Thank you :) but I have an issue with breakpoints. Don't know how to match ones that you have in css-utils and the ones that I've calculated.

Some strange issues with images inside diamonds, looks like some relative positions are ignored.

Also need some refactoring. (Some duplicated logic with height calculation)

@margalencia And there is a question of ordering the diamonds for a11y.

ro-abramov commented 5 years ago

localhost_8000_1366px localhost_8000_ 767px localhost_8000_ 1100px localhost_8000_ iphone 5_se

ro-abramov commented 5 years ago

also fixed #228

ro-abramov commented 5 years ago

There is only one issue left behind related to events diamonds on mobile (colors and background images), but to implement it I need one more breakpoint - and work on the whole media system. I would like to suggest to leave main page with these issue, and create a separate story for fixing all issues related to responsiveness, and I wanna work on these issue. @kitos If it is acceptable, could you please review my changes.