search

WebReflection / basicHTML

A NodeJS based, standard oriented, HTML implementation.
ISC License
126 stars 10 forks source link

feat(Text): implement wholeText #15

Closed bigopon closed 6 years ago

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.002%) to 99.892% when pulling 662ec2eea5cb0ab197e4df3ab056161152956351 on bigopon:master into ece0c7287fe40c7e9c59437b0addd2239e65d63f on WebReflection:master.

WebReflection commented 6 years ago

Thanks @bigopon , I've discovered something new today !!!

However, this project will stay 100% code covered so without any test I won't merge it.

Why is that? For instance, you have two infinite loops and one typo in your PR, with a test you would have easily discovered both 😉

Mind adding a test and fixing issues ? Thanks !

bigopon commented 6 years ago

@WebReflection done. Was unable to get branches to 100% though. I'm also not sure about the coverage report so I excluded it in fix commit. moral of the story: run test when PR 😄