Text and Comment classes should implement `ChildNode` interface?

[coreyfarrell]

I found this while using basichtml for some testing. Minimal failing test case:

const assert = require('assert');
const {body} = require('basichtml').init().document;

body.innerHTML = 'Text<!--comment-->';
[...body.childNodes].forEach(node => node.remove());
assert.strictEqual(body.innerHTML, '');

This throws TypeError: node.remove is not a function where I expected the test to silently succeed. I realize the whatwg standard doesn't show Text or Comment implementing ChildNode but https://developer.mozilla.org/en-US/docs/Web/API/CharacterData#Browser_compatibility shows that CharacterData implements ChildNode in most browsers.

[WebReflection]

yes, it looks like by standards these should be allowed in CharacterData: https://dom.spec.whatwg.org/#childnode

[coreyfarrell]

I had asked about the spec vs MDN docs in the #whatwg IRC channel and was just told that it was listed under childnode (somehow I didn't see this when reading the specs).

[WebReflection]

ChracterData includes ChildNodes

[WebReflection]

It's in the patch 👋