Add qt5-quickcontrols2 to installed packages

WebReflection / benja

Bootable Electron Node JS Application

https://archibold.io/benja/

194 stars 32 forks source link

Add qt5-quickcontrols2 to installed packages #46

Closed lahdekorpi closed 6 years ago

lahdekorpi commented 6 years ago

QtWebEngine requires QtQuick.Controls version 2.0 via Controls2Delegates/Menu.qml. If not installed, dragging text or opening a context menu inside the WebEngine will cause a crash.

WebReflection commented 6 years ago

Is the version 1 needed at all ?

lahdekorpi commented 6 years ago

I couldn't find any reasons why it would. Have to test it some more though, just to be sure...

WebReflection commented 6 years ago

you know what? I don't know why version 1 was in but I'm one of those developers that doesn't bring in dependencies by accident so there was probably a reason and 6MB uncompressed package won't be the end of the world.

lahdekorpi commented 6 years ago

I've now confirmed that both versions are in fact needed. Some QT elements are still using the old one and crash if it's missing.