search

WebReflection / create-viperhtml-app

A basic viperHTML + hyperHTML setup
35 stars 4 forks source link

Update both hyperHTML and viperHTML dependencies to v2.x.x #1

Closed nuragic closed 5 years ago

nuragic commented 6 years ago

Hi Andrea,

I was playing around with this repo trying to build something simple and I found out that dependencies were out of date, so I've just updated both to the latest version.

Besides (this is just a question), I found some difference between the official docs and viper/view/README.md which says:

attributes, as well as events, should be defined within single or double quotes (even boolean attributes, yes)

From the docs:

every attribute can be defined with or without quotes

Just wanted to know if it's definitely ok to not use quotes.

I'd also loved to update other deps such as webpack but didn't feel confident for now so perhaps in another PR further on (if needed). 😄

Thanks!

WebReflection commented 5 years ago

Apologies I have completely missed this

Just wanted to know if it's definitely ok to not use quotes.

Yes, it should be fine in every case

nuragic commented 5 years ago

Ha, cool! I thought it was pointless to keep it open (I'm doing a general issues/PRs cleanup heh) but it eventually got merged 😄 Thanks!

WebReflection commented 5 years ago

thank you!