WebReflection / dblite

sqlite for node.js without gyp problems
MIT License
209 stars 34 forks source link

db.plain returns parsed value anyway #37

Closed rumkin closed 7 years ago

rumkin commented 9 years ago

Accordingly with this line 275 variable dontParseCSV will be equal false always on the check at the line 285.

WebReflection commented 9 years ago

cn you please provide a failing example?

rumkin commented 9 years ago

Sure.

var db = dblite('store.db');
db.plain('SELECT * FROM some_table;', function(err, unparsed) {
    console.log(typeof unparsed); // -> object (should be a string)
});
WebReflection commented 9 years ago

that is doing what it's expect to do ... can you please provide me an example that shows any real problem?

rumkin commented 9 years ago

Isn't plain method should return unparsed CSV string instead of Object?

WebReflection commented 9 years ago

you are right, I'm blind. I've read that as db.query ..... and 0.7.6 should work as expected. Thanks

rumkin commented 9 years ago

You are welcome