Angular Elements: ReferenceError: global is not defined in 1.11.1

mnicic commented 6 years ago

I'm getting the following error on my very simple Angular Elements project with document-register-element@1.11.1:

Uncaught ReferenceError: global is not defined
    at Object.mTVt (ng-element.js:2)
    at p (ng-element.js:1)
    at Object.hN/g (ng-element.js:2)
    at p (ng-element.js:1)
    at Object.2 (ng-element.js:2)
    at p (ng-element.js:1)
    at n (ng-element.js:1)
    at Array.e [as push] (ng-element.js:1)
    at ng-element.js:2

I tried some (working) solution by adding the following in the <head> of HTML. But it's not suitable for my project:

<script>
    var global = global || window;
    var Buffer = Buffer || [];
    var process = process || {
        env: { DEBUG: undefined },
        version: []
    };
</script>

But when I downgrade to v1.9.1 everything is working correctly, without the script in the <head>. What is going wrong with newer versions?

WebReflection commented 6 years ago

I've no idea how you are loading the polyfill so I don't know what's going on 'cause I use this daily without issues

WebReflection commented 6 years ago

also this works http://webreflection.github.io/document-register-element/test/

mnicic commented 6 years ago

These are my imports for polyfills (zone.js is imported directly in HTML):

import 'core-js/es6/symbol';
import 'core-js/es6/object';
import 'core-js/es6/function';
import 'core-js/es6/parse-int';
import 'core-js/es6/parse-float';
import 'core-js/es6/number';
import 'core-js/es6/math';
import 'core-js/es6/string';
import 'core-js/es6/date';
import 'core-js/es6/array';
import 'core-js/es6/regexp';
import 'core-js/es6/map';
import 'core-js/es6/weak-map';
import 'core-js/es6/set';

/** IE10 and IE11 requires the following for NgClass support on SVG elements */
// import 'classlist.js';  // Run `npm install --save classlist.js`.

/** IE10 and IE11 requires the following for the Reflect API. */
import 'core-js/es6/reflect';

/** Evergreen browsers require these. **/
// Used for reflect-metadata in JIT. If you use AOT (and only Angular decorators), you can remove.
import 'core-js/es7/reflect';

/**
 * Web Animations `@angular/platform-browser/animations`
 * Only required if AnimationBuilder is used within the application and using IE/Edge or Safari.
 * Standard animation support in Angular DOES NOT require any polyfills (as of Angular 6.0).
 **/
// import 'web-animations-js';  // Run `npm install --save web-animations-js`.

/**
 * By default, zone.js will patch all possible macroTask and DomEvents
 * user can disable parts of macroTask/DomEvents patch by setting following flags
 */

 // (window as any).__Zone_disable_requestAnimationFrame = true; // disable patch requestAnimationFrame
 // (window as any).__Zone_disable_on_property = true; // disable patch onProperty such as onclick
 // (window as any).__zone_symbol__BLACK_LISTED_EVENTS = ['scroll', 'mousemove']; // disable patch specified eventNames

 /*
 * in IE/Edge developer tools, the addEventListener will also be wrapped by zone.js
 * with the following flag, it will bypass `zone.js` patch for IE/Edge
 */
// (window as any).__Zone_enable_cross_context_check = true;

/***************************************************************************************************
 * Zone JS is required by default for Angular itself.
 */
// import 'zone.js/dist/zone';  // Included with Angular CLI.

/***************************************************************************************************
 * APPLICATION IMPORTS
 */

import 'document-register-element';

WebReflection commented 6 years ago

have you tried importing it before everything else ?

WebReflection commented 6 years ago

also, are you sure your bundler understands CJS ? 'cause if it does, it should understand the module is a CJS one, otherwise you need to import document-register-element/build/document-register-element.js explicitly.

mnicic commented 6 years ago

Yeah, it solved by replacing

import 'document-register-element';

with

import 'document-register-element/build/document-register-element.js'

Thanks!

WebReflection / document-register-element

Angular Elements: ReferenceError: global is not defined in 1.11.1 #150