search

WebReflection / hyperHTML-Element

An extensible class to define hyperHTML based Custom Elements.
ISC License
202 stars 25 forks source link

Fixed Browsers which support Symbol.hasInstance #28

Closed anthony-redFox closed 6 years ago

anthony-redFox commented 6 years ago

https://webreflection.github.io/hyperHTML-Element/test/?es5 - was broken in Chrome and Firefox in 1.8 version

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4ca6f9d5070d360c64e1416cefb6fdb7525c8d56 on anthony-redFox:master into d6e6613d268515d51fc47a1b70d6cd59b191dbbf on WebReflection:master.

WebReflection commented 6 years ago

Thanks @anthony-redFox , I've pushed myself a slightly different version of your change to avoid duplication, this is because the other change I was going to push would've conflicted with this, I hope that is fine.

v1.8.2 has solved that problem. There is still a Babel issue in inheriting builtins in es5 and until I have time to see if babel 7 would work there, please ignore that error and also don't extend builtins if you transpile (at least for now).