search

WebReflection / hyperHTML-Element

An extensible class to define hyperHTML based Custom Elements.
ISC License
202 stars 25 forks source link

Fix built-in elements inheritance #63

Closed fsodano closed 4 years ago

fsodano commented 4 years ago

Due to built-in elements extending the standard HTML Classes, there's a need to add HyperHTMLElement's own class members as well.

HyperHTMLElement assumed the Super class was going to be itself, this commit fixes that by explicitly adding HyperHTMLElement own keys to the Intermediate class used to create our own built-in element extension.

Fixes #62

coveralls commented 4 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling e5d799f73fd1c74acb3301267b2151183b432bc3 on fsodano:feature/fix-builtin-inheritance into ba9eed2f14ac01a314c8e2fbad0f40f157835e30 on WebReflection:master.

WebReflection commented 4 years ago

First of all, thank you!

Secondly, this is landing as minor semver change, simply because it could cause undesired side-effects for those that trusted current behavior until now.

In few words, hyperhtml-element@3.12.0 is out with these changes in, and I hope everything will work as expected 👋

fsodano commented 4 years ago

Awesome, thanks @WebReflection !

fsodano commented 4 years ago

@WebReflection one more: did I have to commit the results of npm build?

Update: I was asking this because the new version doesn't have my changes. It seems this commit reverted them? https://github.com/WebReflection/hyperHTML-Element/commit/2566bff59afbd4c23284013f17de043645672d07#diff-168726dbe96b3ce427e7fedce31bb0bcL2375

Let me know :)