search

WebReflection / hyperHTML-Element

An extensible class to define hyperHTML based Custom Elements.
ISC License
202 stars 25 forks source link

Update TypeScript definition of 'get defaultState'. #78

Closed abaksha-sc closed 2 years ago

abaksha-sc commented 2 years ago

Now it's impossible to define getter for 'defaultState' with TypeScript. Following error appears: "'defaultState' is defined as a property in class 'HyperHTMLElement<{}>', but is overridden here in 'MyComponent' as an accessor." See full description in issue: https://github.com/WebReflection/hyperHTML-Element/issues/77

This is because defaultState is defined as just readonly property when it should be described as getter. Description for 'defaultState' was updated to define it as 'getter'

coveralls commented 2 years ago

Coverage Status

Coverage remained the same at 96.581% when pulling f53a2f36e9b3a4c94ddff8bb16d667fb54d91f82 on abaksha-sc:Fix-for-defaultState into c953fe529d685ed59dfc7d9e0ff4818e252b5351 on WebReflection:master.

WebReflection commented 2 years ago

Thanks, it's up and running 👋