search

WebReflection / hyperHTML

A Fast & Light Virtual DOM Alternative
ISC License
3.07k stars 112 forks source link

Majinbuu dependencie #143

Closed amoutonbrady closed 6 years ago

amoutonbrady commented 6 years ago

Hey, I really love your library and I've been following the changes in the past few weeks.

Since you reverted back to using Majinbuu, I wonder if that shouldn't be listed in the dependencies back too?

Sorry if that's a silly question.

WebReflection commented 6 years ago

Yes, it probably should, sorry

amoutonbrady commented 6 years ago

Don't be sorry, you're doing an amazing job and I'm glad I could "help" :)

WebReflection commented 6 years ago

I've rushed too many patches lately after freaking out for something I've measured wrong.

majinbuu is a "fake" dependency needed only on build time, it's indeed loaded via unpkg.cdn directly as regular ESM module.

I am planning to release hyperHTML with a dumb/simple engine and make majinbuu optional but since I don't want to rush patches anymore I am probaly keeping this package as it is.

TL;DR this does not affect the usage of the library, but I'll keep this bug open until everything is properly solved.

Thanks again for the repo

WebReflection commented 6 years ago

FYI majinbuu based render-engine is now fully provided a part: https://github.com/WebReflection/hyperhtml-majinbuu