WebReflection / hyperHTML

A Fast & Light Virtual DOM Alternative
ISC License
3.07k stars 113 forks source link

lightercollective switched to optional dependency #252

Closed 8eecf0d2 closed 6 years ago

8eecf0d2 commented 6 years ago

While I'm a big fan and do currently support on patreon - it seems a bit over the top to force the installation of the opencollective / lightercollective package (now much smaller but that's not really the point).

This change will allow people to pass the --no-optional flag when installing to prevent optionals from being installed.

side note: lightercollective feature doesn't work with yarn.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at ?% when pulling c7accc16529df8469cc9fb1a9623b935349bb449 on 8eecf0d2:master into 686221a516581644f68c79dde9c6556d5106d9f4 on WebReflection:master.

WebReflection commented 6 years ago

it seems a bit over the top to force the installation of the opencollective / lightercollective package

no open collective is needed, lightercollective is 4KB

(now much smaller but that's not really the point).

that is the whole point.

side note: lightercollective feature doesn't work with yarn.

if you support this project, you might rather help with making this work on yarn too.

As quick reminder:

I've closed before people asking me to drop what's absolutely irrelevant for them, but a valid Open Source way to wave everyone out there Open Source doesn't mean free.

Unless convinced otherwise this is an issue, I don't think it's even nice, as supporter of the project, to be ever bothered by a tiny log while installing.

8eecf0d2 commented 6 years ago

that is the whole point.

That's the point of lightercollective which is great, but not the point of my pull request.

Either way I understand and will hopefully be able to contribute in a more meaningful way in the future.

8eecf0d2 commented 6 years ago

yarn postinstall stdout ref: yarnpkg/yarn#5476

WebReflection commented 6 years ago

On a second though, the postinstall script runs lightercollective so if it's not there, there would be an error, right? For the time being I'll close this as wont fix, but if you have a solution for optional and postscript based on optional that doesn't error, I might eventually consider.

Yet, I really struggle to understand what is the issue in having a logo and a link to support software you are using and only while installing it, which is once in a while, not daily (and automations won't read the log, and won't ever care).