search

WebReflection / hyperHTML

A Fast & Light Virtual DOM Alternative
ISC License
3.07k stars 112 forks source link

create-content seems included twice #315

Closed brunoscopelliti closed 5 years ago

brunoscopelliti commented 5 years ago

In the current latest version, @ungap/create-content seems to be included twice.

To verify, open previous link, and search for var createContent; you'll find matches for var createContent and var createContent$1, but the code is almost identical. Is this expected?

WebReflection commented 5 years ago

it looks like a rollup plugin issue https://stackoverflow.com/questions/53302600/rollup-babel-duplicate-definitions-in-output-file

brunoscopelliti commented 5 years ago

Does your previous commit fix the issue with rollup, or we've to wait for a fix on rollup itself?

WebReflection commented 5 years ago

I've monkey-patched the issue and took the opportunity to update the whole rollup stack, however not much gain once compressed since repeated content size is usually irrelevant.

anyway, good catch, thanks for filing this.