search

WebReflection / hyperHTML

A Fast & Light Virtual DOM Alternative
ISC License
3.06k stars 112 forks source link

unquoted attributes with / crash #359

Closed atirip closed 5 years ago

atirip commented 5 years ago

https://codepen.io/anon/pen/EJqMXO?editors=0011

This throws:

   var a = 'go';
   hyperHTML.wire()`<link rel=stylesheet type=text/css href=${a}>`;

Adding quotes around (type="text/css") works.

WebReflection commented 5 years ago

that's how standard works

atirip commented 5 years ago

https://validator.w3.org/nu/#textarea says: Document checking completed. No errors or warnings to show.

<!doctype html><html lang=en><title>document</title><link rel=stylesheet type=text/css href=foo.css><p>hello world!

WebReflection commented 5 years ago

fair enough, I thought slashes were not possible. However, this is a domtagger issue, not an hyperHTML one.

WebReflection commented 5 years ago

OK, this has been solved all over the place (including lighterhtml)

Thanks for filing the bug 👋