Closed yuretz closed 2 years ago
Totals | |
---|---|
Change from base Build 1315038057: | 0.0% |
Covered Lines: | 314 |
Relevant Lines: | 347 |
Thanks for merging it Andrea, very much appreciated! 🙏 Do you think you would be able to publish a new version to npm sometime soon?
@yuretz apologies I'm on vacation it took your reminder to remind me to do that ... which I did now 👋
This is a tiny change to the .d.ts file that solves the issue described here with
defaultState
not being declared exactly the same way it was implemented and upsetting the type checker when e.g. overridden in a class derived from theComponent
.get/set declarations in
d.ts
files should be supported since 3.6 release of TypeScript, which was 3 years ago. So, while in theory someone using hyperHTML with an older TS version is most likely to get unexpected type checking errors because of this change, but in practice there wouldn't be many people like this, I assume. I don't quite know what's your policy regarding breaking changes in the type declarations file, but now you know about it's potential effect.Maybe TS compatibility warrants a note in the Readme somewhere, what do you think?